From 56a893563b610d091b26e6cde1f7da508bcac7bc Mon Sep 17 00:00:00 2001
From: Hunter Bown <hmbown@gmail.com>
Date: Mon, 11 May 2026 23:32:00 -0500
Subject: [PATCH] ci(auto-close): replace heredoc with printf so YAML block
 scalar parses
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The `<<EOF` heredoc inside the `run: |` step body broke YAML parsing —
heredoc bodies have to start at column 0, but YAML block scalars
require consistent indentation. Both runs of the new workflow on the
v0.8.31 push failed at the workflow-file validation stage with
`expected a comment or a line break, but found '$'` at line 128.

Switching to `printf '%s\n' "line1" "line2" ...` keeps every line of
the message at the same indent as the surrounding shell code, so the
YAML `|` scalar stays consistent. Behaviour is identical from the
contributor's perspective.

Confirmed locally with `python3 -c 'import yaml; yaml.safe_load(...)'`
before pushing.
---
 .github/workflows/auto-close-harvested.yml | 28 ++++++++++++++--------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/auto-close-harvested.yml b/.github/workflows/auto-close-harvested.yml
index 8cbf769e..1547ab96 100644
--- a/.github/workflows/auto-close-harvested.yml
+++ b/.github/workflows/auto-close-harvested.yml
@@ -122,16 +122,24 @@ jobs:
                 greeting="Thanks @${author}"
               fi
 
-              body_text=$(cat <<EOF
-${greeting} — your contribution landed in [\`${short_sha}\`](https://github.com/${GITHUB_REPOSITORY}/commit/${sha}) on \`main\`:
-
-> ${subject}
-
-Closing this PR now that the code is on \`main\`. Credit lives in the commit message and (where applicable) the \`CHANGELOG.md\` entry for the next release. Apologies for not closing this at the time of the merge — the auto-close workflow is new in v0.8.31.
-
-If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the [\`CONTRIBUTING.md\`](https://github.com/${GITHUB_REPOSITORY}/blob/main/CONTRIBUTING.md) doc has a short note on what makes a contribution mergeable as-is.
-EOF
-              )
+              # NOTE: this block intentionally avoids `<<EOF` heredocs.
+              # YAML's `|` block scalar requires consistent indentation,
+              # but heredoc bodies have to start at column 0 — those two
+              # constraints can't coexist in the same file. We assemble
+              # the body with `printf` + `\n` so every line of the
+              # message lives at the same indent as the surrounding
+              # shell code.
+              commit_url="https://github.com/${GITHUB_REPOSITORY}/commit/${sha}"
+              contributing_url="https://github.com/${GITHUB_REPOSITORY}/blob/main/CONTRIBUTING.md"
+              body_text="$(printf '%s\n' \
+                "${greeting} — your contribution landed in [\`${short_sha}\`](${commit_url}) on \`main\`:" \
+                "" \
+                "> ${subject}" \
+                "" \
+                "Closing this PR now that the code is on \`main\`. Credit lives in the commit message and (where applicable) the \`CHANGELOG.md\` entry for the next release. Apologies for not closing this at the time of the merge — the auto-close workflow is new in v0.8.31." \
+                "" \
+                "If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the [\`CONTRIBUTING.md\`](${contributing_url}) doc has a short note on what makes a contribution mergeable as-is." \
+              )"
 
               echo "Closing PR #${pr} (harvested in ${short_sha})"
               if ! gh pr close "${pr}" \