From 593ed2f9001889f5b5d2eb7c185d5e2280005d53 Mon Sep 17 00:00:00 2001 From: Hunter Bown Date: Thu, 7 May 2026 03:37:22 -0500 Subject: [PATCH] fix(npm): preserve -v passthrough Summary: - Stop treating -v as an npm wrapper version fallback. - Keep wrapper fallback for --version and -V. - Add a Node regression test for wrapper version flag detection. Test plan: - npm test from npm/deepseek-tui - git diff --check origin/main...HEAD Supersedes #959. --- npm/deepseek-tui/package.json | 4 +++- npm/deepseek-tui/scripts/run.js | 6 +++--- npm/deepseek-tui/test/run.test.js | 11 +++++++++++ 3 files changed, 17 insertions(+), 4 deletions(-) create mode 100644 npm/deepseek-tui/test/run.test.js diff --git a/npm/deepseek-tui/package.json b/npm/deepseek-tui/package.json index ba3eebc6..7539c178 100644 --- a/npm/deepseek-tui/package.json +++ b/npm/deepseek-tui/package.json @@ -30,7 +30,8 @@ "release:check": "node scripts/verify-release-assets.js", "postinstall": "node scripts/install.js", "prepublishOnly": "node scripts/verify-release-assets.js", - "prepack": "node scripts/install.js" + "prepack": "node scripts/install.js", + "test": "node --test test/*.test.js" }, "engines": { "node": ">=18" @@ -42,6 +43,7 @@ "files": [ "bin/*.js", "scripts/*.js", + "test/*.js", "README.md", "package.json" ] diff --git a/npm/deepseek-tui/scripts/run.js b/npm/deepseek-tui/scripts/run.js index 23b71321..76cf677e 100644 --- a/npm/deepseek-tui/scripts/run.js +++ b/npm/deepseek-tui/scripts/run.js @@ -3,9 +3,8 @@ const { getBinaryPath } = require("./install"); const pkg = require("../package.json"); -function isVersionFlag() { - const args = process.argv.slice(2); - return args.includes("--version") || args.includes("-v") || args.includes("-V"); +function isVersionFlag(args = process.argv.slice(2)) { + return args.includes("--version") || args.includes("-V"); } function handleVersionFallback(binaryName) { @@ -46,6 +45,7 @@ module.exports = { run, runDeepseek, runDeepseekTui, + _internal: { isVersionFlag }, }; if (require.main === module) { diff --git a/npm/deepseek-tui/test/run.test.js b/npm/deepseek-tui/test/run.test.js new file mode 100644 index 00000000..3b471f1e --- /dev/null +++ b/npm/deepseek-tui/test/run.test.js @@ -0,0 +1,11 @@ +const assert = require("node:assert/strict"); +const test = require("node:test"); + +const { _internal } = require("../scripts/run"); + +test("version fallback handles only version flags", () => { + assert.equal(_internal.isVersionFlag(["--version"]), true); + assert.equal(_internal.isVersionFlag(["-V"]), true); + assert.equal(_internal.isVersionFlag(["-v"]), false); + assert.equal(_internal.isVersionFlag(["--verbose"]), false); +});