From 5d9f93af4d3f98c9f49b6344ca8b86967b7968ee Mon Sep 17 00:00:00 2001 From: Hunter B Date: Fri, 5 Jun 2026 08:06:35 -0700 Subject: [PATCH] fix(tui): expose external URL opener on unsupported targets Harvested from PR #2789 by @ci4ic4. Found while packaging CodeWhale 0.8.53 for pkgsrc on NetBSD. Co-authored-by: ci4ic4 <6495973+ci4ic4@users.noreply.github.com> --- .github/AUTHOR_MAP | 3 +++ CHANGELOG.md | 4 ++++ crates/tui/CHANGELOG.md | 4 ++++ crates/tui/src/tui/ui.rs | 1 - 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/AUTHOR_MAP b/.github/AUTHOR_MAP index 6b55ca30..a3a218cd 100644 --- a/.github/AUTHOR_MAP +++ b/.github/AUTHOR_MAP @@ -74,6 +74,9 @@ xrnc@outlook.com = elowen53 <88364845+elowen53@users.noreply.github.com> CrepuscularIRIS = CrepuscularIRIS <126939795+CrepuscularIRIS@users.noreply.github.com> chnjames = chnjames <44110547+chnjames@users.noreply.github.com> ChaceLyee2101 = ChaceLyee2101 <95995339+ChaceLyee2101@users.noreply.github.com> +ci4ic4 = ci4ic4 <6495973+ci4ic4@users.noreply.github.com> +Chavdar Ivanov = ci4ic4 <6495973+ci4ic4@users.noreply.github.com> +ci4ic4@gmail.com = ci4ic4 <6495973+ci4ic4@users.noreply.github.com> AresNing = AresNing <49557311+AresNing@users.noreply.github.com> shenjackyuanjie = shenjackyuanjie <54507071+shenjackyuanjie@users.noreply.github.com> diff --git a/CHANGELOG.md b/CHANGELOG.md index 3cc71d06..9314e774 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -161,6 +161,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Browser-opening actions now compile on non-desktop targets by delegating the + unsupported-platform error to the shared URL opener instead of hiding the TUI + wrapper behind a narrower macOS/Linux/Windows cfg. Thanks @ci4ic4 for the + NetBSD/pkgsrc packaging report and fix (#2789). - MCP tool routing now preserves server names that contain underscores. `parse_prefixed_name` matches the qualified `mcp__` name against the set of registered server names and prefers the longest match, so tools on diff --git a/crates/tui/CHANGELOG.md b/crates/tui/CHANGELOG.md index 3cc71d06..9314e774 100644 --- a/crates/tui/CHANGELOG.md +++ b/crates/tui/CHANGELOG.md @@ -161,6 +161,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Browser-opening actions now compile on non-desktop targets by delegating the + unsupported-platform error to the shared URL opener instead of hiding the TUI + wrapper behind a narrower macOS/Linux/Windows cfg. Thanks @ci4ic4 for the + NetBSD/pkgsrc packaging report and fix (#2789). - MCP tool routing now preserves server names that contain underscores. `parse_prefixed_name` matches the qualified `mcp__` name against the set of registered server names and prefers the longest match, so tools on diff --git a/crates/tui/src/tui/ui.rs b/crates/tui/src/tui/ui.rs index 0ec107e7..23974140 100644 --- a/crates/tui/src/tui/ui.rs +++ b/crates/tui/src/tui/ui.rs @@ -6093,7 +6093,6 @@ async fn apply_command_result( #[cfg(test)] use std::process::{Command, Stdio}; -#[cfg(any(target_os = "macos", target_os = "linux", target_os = "windows"))] fn open_external_url(url: &str) -> Result<()> { crate::utils::open_url(url) }