fix: address self-review findings
This commit is contained in:
@@ -1952,9 +1952,13 @@ fn should_skip_secret_store_for_provider(
|
|||||||
fn env_api_key_for_provider(provider: ProviderKind) -> Option<String> {
|
fn env_api_key_for_provider(provider: ProviderKind) -> Option<String> {
|
||||||
if provider == ProviderKind::Huggingface {
|
if provider == ProviderKind::Huggingface {
|
||||||
return std::env::var("HUGGINGFACE_API_KEY")
|
return std::env::var("HUGGINGFACE_API_KEY")
|
||||||
.or_else(|_| std::env::var("HF_TOKEN"))
|
|
||||||
.ok()
|
.ok()
|
||||||
.filter(|value| !value.trim().is_empty());
|
.filter(|value| !value.trim().is_empty())
|
||||||
|
.or_else(|| {
|
||||||
|
std::env::var("HF_TOKEN")
|
||||||
|
.ok()
|
||||||
|
.filter(|value| !value.trim().is_empty())
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
codewhale_secrets::env_for(provider.as_str())
|
codewhale_secrets::env_for(provider.as_str())
|
||||||
@@ -4825,6 +4829,24 @@ model = "mimo-v2.5-pro"
|
|||||||
assert_eq!(resolved.model, "org/short-model");
|
assert_eq!(resolved.model, "org/short-model");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn huggingface_token_fallback_resolves_when_primary_api_key_is_blank() {
|
||||||
|
let _lock = env_lock();
|
||||||
|
let _env = EnvGuard::without_deepseek_runtime_overrides();
|
||||||
|
// Safety: test-only environment mutation guarded by a module mutex.
|
||||||
|
unsafe {
|
||||||
|
env::set_var("CODEWHALE_PROVIDER", "huggingface");
|
||||||
|
env::set_var("HUGGINGFACE_API_KEY", " ");
|
||||||
|
env::set_var("HF_TOKEN", "hf-token-fallback");
|
||||||
|
}
|
||||||
|
|
||||||
|
let resolved =
|
||||||
|
ConfigToml::default().resolve_runtime_options(&CliRuntimeOverrides::default());
|
||||||
|
|
||||||
|
assert_eq!(resolved.provider, ProviderKind::Huggingface);
|
||||||
|
assert_eq!(resolved.api_key.as_deref(), Some("hf-token-fallback"));
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn siliconflow_cn_base_url_env_normalizes_model_aliases() {
|
fn siliconflow_cn_base_url_env_normalizes_model_aliases() {
|
||||||
let _lock = env_lock();
|
let _lock = env_lock();
|
||||||
|
|||||||
Reference in New Issue
Block a user