From c0e27485a848693ddd85e6aea8f7ad9fd217fa1d Mon Sep 17 00:00:00 2001 From: Hunter Bown Date: Tue, 5 May 2026 00:44:13 -0500 Subject: [PATCH] =?UTF-8?q?fix:=20remove=20dead=20config=20fields=20?= =?UTF-8?q?=E2=80=94=20prefer=5Fhandoff=20(#667)=20and=20use=5Fterminal=5F?= =?UTF-8?q?colors=20(#671)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Neither field had any code path that read it. Shipping config knobs that do nothing trains users to mistrust config. Remove until the implementation exists. --- config.example.toml | 1 - crates/tui/src/compaction.rs | 5 ----- crates/tui/src/config.rs | 3 --- 3 files changed, 9 deletions(-) diff --git a/config.example.toml b/config.example.toml index 038690cc..2bee9a0b 100644 --- a/config.example.toml +++ b/config.example.toml @@ -229,7 +229,6 @@ osc8_links = true # emit OSC 8 escapes around URLs (Cmd+click in iTer # # Override: `locale = "zh-Hans"` for Simplified Chinese regardless of OS locale. # # Also settable at runtime: /config locale zh-Hans # # Note: this only affects TUI labels/chrome — it does NOT change model output language. -# use_terminal_colors = false # set true to let your terminal's color scheme take full control # ───────────────────────────────────────────────────────────────────────────────── # Feature Flags diff --git a/crates/tui/src/compaction.rs b/crates/tui/src/compaction.rs index e2c2dac0..59ecc3c4 100644 --- a/crates/tui/src/compaction.rs +++ b/crates/tui/src/compaction.rs @@ -38,10 +38,6 @@ pub struct CompactionConfig { /// logic at small fixture sizes can set this to `0` to disable the /// floor. pub auto_floor_tokens: usize, - /// When `Some(true)`, the engine prefers writing a handoff file over - /// running LLM-based compaction when context pressure triggers. - /// `None` / `Some(false)` means default compaction behaviour. - pub prefer_handoff: Option, } impl Default for CompactionConfig { @@ -63,7 +59,6 @@ impl Default for CompactionConfig { model: DEFAULT_TEXT_MODEL.to_string(), cache_summary: true, auto_floor_tokens: MINIMUM_AUTO_COMPACTION_TOKENS, - prefer_handoff: None, } } } diff --git a/crates/tui/src/config.rs b/crates/tui/src/config.rs index d7831c5f..7f4b0532 100644 --- a/crates/tui/src/config.rs +++ b/crates/tui/src/config.rs @@ -343,9 +343,6 @@ pub struct TuiConfig { /// label and ignore the escape. Defaults to `true`; set `false` for /// terminals that misrender the sequence. pub osc8_links: Option, - /// When true, TUI uses Color::Reset everywhere and defers all color decisions - /// to the terminal emulator. Useful for terminals with custom color schemes. - pub use_terminal_colors: Option, } /// Notification delivery method (mirrors `tui::notifications::Method`).