Files
codewhale/crates
Zhongyue Lin 0ce41505bc fix(shell): robust cmd detection + stronger test assertion (review #1744)
Address gemini-code-assist review on PR #1744 (two MEDIUM):

- cmd detection used program.eq_ignore_ascii_case("cmd"), which fails
  for a full path (C:\Windows\System32\cmd.exe) or a .exe suffix, so the
  raw_arg quoting fix would not apply. Use Path::file_stem() instead
  (fully-qualified std::path::Path -> no unused import off-Windows).
- Strengthen the Windows block of issue_1691_quoted_commit_message_round_trips
  to assert argv content equals spec.args, not just arg count, so the
  raw_arg payload (quotes preserved, no extra escaping) is actually
  verified. sandbox/mod.rs already asserts content -- left untouched.

Windows paths are cfg-gated (compile-checked on macOS, executed on
Windows CI). macOS build + clippy clean.

Refs #1691.
2026-05-18 23:06:52 +08:00
..
2026-05-17 16:36:21 +08:00
2026-05-17 16:36:21 +08:00
2026-05-17 16:36:21 +08:00
2026-05-17 16:36:21 +08:00
2026-05-17 16:36:21 +08:00
2026-05-14 00:31:18 -05:00
2026-05-17 16:36:21 +08:00