fix(tui): drop thinking from cell_has_detail_target; credit README contributors
Fixes the macOS test failure on PR #1988 and the contributor-credit gate from scripts/release/check-versions.sh. cell_has_detail_target() was matching HistoryCell::Thinking, which caused the activity footer to append " · ⌥+V raw" to thinking cells that have no separate raw detail target. The detail-card flow only exists for tool / sub-agent cells; thinking renders its own raw text inline. Removing Thinking from the match arm restores the behavior the existing activity_footer_hint_surfaces_visible_thinking_without_raw_tool_hint test asserts. The CHANGELOG.md 0.8.43 section now credits the 30 contributors added to README acknowledgements in this cycle, satisfying the README-vs- CHANGELOG cross-check in check-versions.sh. crates/tui/CHANGELOG.md is re-synced so the matching guard passes. Verified locally on macOS: - cargo fmt --all -- --check : clean - cargo clippy --workspace --all-targets --all-features --locked -D warnings : clean - cargo test --workspace --all-features --locked : 41 suites, 0 failed - ./scripts/release/check-versions.sh : Version state OK - ./scripts/release/publish-crates.sh dry-run : all 14 crates OK - cargo build --release --locked : clean Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -60,6 +60,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
package text, and website copy now consistently position CodeWhale as
|
||||
open-model-first and provider-spanning, with DeepSeek V4 as the first-class
|
||||
path.
|
||||
- **New contributor names added to README acknowledgements.** Thanks to
|
||||
@Apeiron0w0, @aqilaziz, @ChaceLyee2101, @ComeFromTheMars, @CrepuscularIRIS,
|
||||
@dst1213, @eltociear, @fuleinist, @greyfreedom, @h3c-hexin, @heloanc,
|
||||
@hxy91819, @J3y0r, @JiarenWang, @jinpengxuan, @KhalidAlnujaidi, @laoye2020,
|
||||
@lbcheng888, @linzhiqin2003, @Liu-Vince, @lixiasky-back, @pengyou200902,
|
||||
@punkcanyang, @Rene-Kuhm, @SamhandsomeLee, @sockerch, @sternelee,
|
||||
@Wenjunyun123, @whtis, and @wuwuzhijing for the translations, typo fixes,
|
||||
docs polish, and small UX improvements that landed across the 0.8.42 →
|
||||
0.8.43 cycle.
|
||||
|
||||
### Security
|
||||
|
||||
|
||||
@@ -60,6 +60,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
package text, and website copy now consistently position CodeWhale as
|
||||
open-model-first and provider-spanning, with DeepSeek V4 as the first-class
|
||||
path.
|
||||
- **New contributor names added to README acknowledgements.** Thanks to
|
||||
@Apeiron0w0, @aqilaziz, @ChaceLyee2101, @ComeFromTheMars, @CrepuscularIRIS,
|
||||
@dst1213, @eltociear, @fuleinist, @greyfreedom, @h3c-hexin, @heloanc,
|
||||
@hxy91819, @J3y0r, @JiarenWang, @jinpengxuan, @KhalidAlnujaidi, @laoye2020,
|
||||
@lbcheng888, @linzhiqin2003, @Liu-Vince, @lixiasky-back, @pengyou200902,
|
||||
@punkcanyang, @Rene-Kuhm, @SamhandsomeLee, @sockerch, @sternelee,
|
||||
@Wenjunyun123, @whtis, and @wuwuzhijing for the translations, typo fixes,
|
||||
docs polish, and small UX improvements that landed across the 0.8.42 →
|
||||
0.8.43 cycle.
|
||||
|
||||
### Security
|
||||
|
||||
|
||||
@@ -2561,15 +2561,14 @@ impl App {
|
||||
}
|
||||
|
||||
/// Whether a virtual transcript cell can open a meaningful Alt+V detail
|
||||
/// view.
|
||||
/// view. Thinking cells render their own raw text inline so there is no
|
||||
/// separate "raw" target — only tool / sub-agent cells get the hint.
|
||||
#[must_use]
|
||||
pub fn cell_has_detail_target(&self, index: usize) -> bool {
|
||||
self.tool_detail_record_for_cell(index).is_some()
|
||||
|| matches!(
|
||||
self.cell_at_virtual_index(index),
|
||||
Some(
|
||||
HistoryCell::Tool(_) | HistoryCell::SubAgent(_) | HistoryCell::Thinking { .. }
|
||||
)
|
||||
Some(HistoryCell::Tool(_) | HistoryCell::SubAgent(_))
|
||||
)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user